{"id":6458,"date":"2020-11-14T14:23:01","date_gmt":"2020-11-14T12:23:01","guid":{"rendered":"http:\/\/mummila.net\/kommentit\/?p=6458"},"modified":"2020-11-14T14:23:31","modified_gmt":"2020-11-14T12:23:31","slug":"build-sh-uses-bashisms-but-shebangs-bin-sh","status":"publish","type":"post","link":"https:\/\/mummila.net\/kommentit\/2020\/11\/14\/build-sh-uses-bashisms-but-shebangs-bin-sh\/","title":{"rendered":"build.sh uses bashisms, but shebangs \/bin\/sh"},"content":{"rendered":"<p>1.37.0 fails to build in my build environment (Ubuntu 18.04 in LXC) with this error:<\/p>\n<pre><code>ubuntu@mattermost-mobile:~\/mattermost-mobile$ npm run build:android\r\n\r\n&gt; mattermost-mobile@1.37.0 build:android \/home\/ubuntu\/mattermost-mobile\r\n&gt; .\/scripts\/build.sh apk\r\n\r\n.\/scripts\/build.sh: 3: .\/scripts\/build.sh: Syntax error: \"(\" unexpected\r\nnpm ERR! code ELIFECYCLE\r\nnpm ERR! errno 2\r\nnpm ERR! mattermost-mobile@1.37.0 build:android: `.\/scripts\/build.sh apk`\r\nnpm ERR! Exit status 2\r\nnpm ERR! \r\nnpm ERR! Failed at the mattermost-mobile@1.37.0 build:android script.\r\nnpm ERR! This is probably not a problem with npm. There is likely additional logging output above.\r\n\r\nnpm ERR! A complete log of this run can be found in:\r\nnpm ERR!     \/home\/ubuntu\/.npm\/_logs\/2020-11-14T11_47_00_288Z-debug.log\r\n<\/code><\/pre>\n<p><a href=\"https:\/\/github.com\/mattermost\/mattermost-mobile\/blob\/30d4aa2a3e9239d61f8bd9e866fb07d7cdeafda5\/scripts\/build.sh#L1\">The top of that file,\u00a0<code>build.sh<\/code>, refers to\u00a0<code>\/bin\/sh<\/code><\/a>, but on Ubuntu and Debian,\u00a0<code>\/bin\/sh<\/code>\u00a0has been Dash for quite a while, whereas\u00a0<code>build.sh<\/code>\u00a0seems to written for Bash (where\u00a0<a href=\"https:\/\/wiki.ubuntu.com\/DashAsBinSh?action=recall&amp;rev=63#function\" rel=\"nofollow\">function is a valid keyword<\/a>):<\/p>\n<pre><code>ubuntu@mattermost-mobile:~\/mattermost-mobile$ head scripts\/build.sh \r\n#!\/bin\/sh\r\n\r\nfunction execute() {\r\n    cd fastlane &amp;&amp; NODE_ENV=production bundle exec fastlane $1 $2\r\n}\r\n<\/code><\/pre>\n<p>I suggest switching the shebang to\u00a0<code>#\/bin\/bash<\/code>, or better yet,\u00a0<code>#!\/usr\/bin\/env bash<\/code>\u00a0(for path-agnosticity). In my environment, using either one fixes the build.<\/p>\n","protected":false},"excerpt":{"rendered":"<p>1.37.0 fails to build in my build environment (Ubuntu 18.04 in LXC) with syntax error. I suggest switching the shebang to #!\/usr\/bin\/env bash.<\/p>\n","protected":false},"author":2,"featured_media":0,"comment_status":"closed","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[8860],"tags":[12572,9864,22836,362,22837,14049,2679],"class_list":["post-6458","post","type-post","status-publish","format-standard","hentry","category-vianhallintajarjestelmat","tag-android","tag-bash","tag-dash","tag-debian","tag-lxc","tag-mattermost","tag-ubuntu","sijainti-github"],"_links":{"self":[{"href":"https:\/\/mummila.net\/kommentit\/wp-json\/wp\/v2\/posts\/6458","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/mummila.net\/kommentit\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/mummila.net\/kommentit\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/mummila.net\/kommentit\/wp-json\/wp\/v2\/users\/2"}],"replies":[{"embeddable":true,"href":"https:\/\/mummila.net\/kommentit\/wp-json\/wp\/v2\/comments?post=6458"}],"version-history":[{"count":1,"href":"https:\/\/mummila.net\/kommentit\/wp-json\/wp\/v2\/posts\/6458\/revisions"}],"predecessor-version":[{"id":6459,"href":"https:\/\/mummila.net\/kommentit\/wp-json\/wp\/v2\/posts\/6458\/revisions\/6459"}],"wp:attachment":[{"href":"https:\/\/mummila.net\/kommentit\/wp-json\/wp\/v2\/media?parent=6458"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/mummila.net\/kommentit\/wp-json\/wp\/v2\/categories?post=6458"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/mummila.net\/kommentit\/wp-json\/wp\/v2\/tags?post=6458"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}