Avainsanana Mattermost

build.sh uses bashisms, but shebangs /bin/sh

14. marraskuuta 2020 klo 14.23
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Android, Bash, Dash, Debian, LXC, Mattermost, Ubuntu

1.37.0 fails to build in my build environment (Ubuntu 18.04 in LXC) with this error:

ubuntu@mattermost-mobile:~/mattermost-mobile$ npm run build:android

> mattermost-mobile@1.37.0 build:android /home/ubuntu/mattermost-mobile
> ./scripts/build.sh apk

./scripts/build.sh: 3: ./scripts/build.sh: Syntax error: "(" unexpected
npm ERR! errno 2
npm ERR! mattermost-mobile@1.37.0 build:android: `./scripts/build.sh apk`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the mattermost-mobile@1.37.0 build:android script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/ubuntu/.npm/_logs/2020-11-14T11_47_00_288Z-debug.log

The top of that file, build.sh, refers to /bin/sh, but on Ubuntu and Debian, /bin/sh has been Dash for quite a while, whereas build.sh seems to written for Bash (where function is a valid keyword):

ubuntu@mattermost-mobile:~/mattermost-mobile$ head scripts/build.sh 

function execute() {
    cd fastlane && NODE_ENV=production bundle exec fastlane $1 $2

I suggest switching the shebang to #/bin/bash, or better yet, #!/usr/bin/env bash (for path-agnosticity). In my environment, using either one fixes the build.

Vastaa viestiin sen kontekstissa (Github)

This hasn’t manifested itself in ages anymore, so it’s probably fixed

30. elokuuta 2020 klo 16.36
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Mattermost

This hasn’t manifested itself in ages anymore, so it’s probably fixed.

Vastaa viestiin sen kontekstissa (Github)

Mobile devices receive ghost notifications for already read messages

29. elokuuta 2020 klo 20.07
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Android, LineageOS, Mattermost, Samsung


Mobile devices receive ”ghost” notifications for already read messages, when set to receive notifications ”when Away or offline”, and receiving user is set to be Away.

Steps to reproduce

  1. Set ”Mobile Push Notifications” to ”Trigger push notifications when”: ”Away or offline” (and send ”For all activity”)
  2. Using web interface on desktop, set your status to Away
  3. (Still in the web interface) receive a message in the currently open channel (which immediately marks it read)

Expected behavior

Nothing happens on the mobile device (no notification).

Observed behavior (that appears unintentional)

The mobile device receives a notification about the already read message. The notification immediately disappears. If you weren’t looking at the device, you’re left wondering why it alerted you.

Other info

If your status is set to Online instead of Away (at step 2), the mobile device receives no notification (as expected). If ”Trigger push notifications when” is set to ”Online, away or offline” (at step 1), the mobile device receives no notification irrespective of your Online/Away status (also as expected).

Environment Information

I’m self-hosting Mattermost 5.26.1 with self-hosted MMPNS 5.22.4. Mattermost Mobile is at version 1.34.0. My mobile devices have Android 10 (Samsung) and Android 7.1.2 (LineageOS 14.1).

I don’t know if this is an issue with the client or the server; I can re-report against the latter if appropriate.

Vastaa viestiin sen kontekstissa (Github)

No subpath, just the plain domain

4. joulukuuta 2019 klo 19.58
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Mattermost

@amyblais No subpath, just the plain domain.

Vastaa viestiin sen kontekstissa (Github)

Here are the banner settings

5. marraskuuta 2019 klo 13.08
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Firefox, Mattermost

Hi @amyblais, thanks for taking a look!

Here are the banner settings:

# grep -i banner config.json 
        "EnablePreviewModeBanner": true,
        "EnableBanner": false,
        "BannerText": "",
        "BannerColor": "#f2a93b",
        "BannerTextColor": "#333333",
        "AllowBannerDismissal": true

I should also mention that I’ve previously enabled Developer Mode ("EnableDeveloper": true), but I’m not sure it’s related, since the notification in this issue has the normal blue background, not a purple one.

The issue reappeared today for the other affected user, then kept disappearing and reappearing under testing, but we were unable to pin down any specific reason. Their browser console (Firefox) only has this:

websocket connecting to wss://[redacted]/api/v4/websocket websocket_client.jsx:35:20

and the server log meanwhile only has this line repeated:

mlog/log.go:174	{"name":"TypeError","message":"NetworkError when attempting to fetch resource.","stack":""}	{"path": "/api/v4/logs", "request_id": "g8wwo8yu57djmkipjxjxn7hy3y", "ip_addr": "[redacted]", "user_id": "[redacted]", "method": "POST", "err_where": "client", "http_code": 0, "err_details": ""}

(where user_id is the one for the affected user.)

Vastaa viestiin sen kontekstissa (Github)

”A new version of Mattermost is available” notification remains after selecting to ”Refresh the app now”

4. marraskuuta 2019 klo 16.52
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Chrome, Firefox, Mattermost


Selecting the ”Refresh the app now” link from update notification doesn’t make the notification go away.

Steps to reproduce

Have MM server updated to latest release. Open an existing session of the web app in Firefox. See the refresh prompt, select ”Refresh the app now”.

Expected behavior

Web page is refreshed, the notification goes away.

Observed behavior (that appears unintentional)

Web page is refreshed, but the update notification is still there, still prompting to refresh.

Verbose version

With some of the most recent updates (perhaps 5.16 and newer), the ”Refresh the app now” link in the update notification (”A new version of Mattermost is available”) on the web app did not make that notification go away for myself and another user. The link did cause a refresh of the page content, but the notification persisted. Meanwhile the version being reported by ”About Mattermost” was the correct (5.16.2).

Ctrl+shift+r or other hard refresh attempts did not have an effect, but logging out and then back in to the site finally did make the notification go away.

We’re both Firefox users, and due to the nature of the issue it was difficult to tell if this was browser-specific, but a fresh login using Chrome (while the previous session in Firefox still showed the notification) did not bring up the notification in the new session.

The issue, though irritatingly persistent while it lasted, was still relatively ephemeral, and now that it’s gone, I wouldn’t know how to reproduce it before the next server update. That said, I’ll happily provide more details if I can.

Vastaa viestiin sen kontekstissa (Github)

Make sure that the value of gcmSenderId still has the trailing backslash

14. tammikuuta 2019 klo 16.44
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Android, Google, Mattermost, Nexus

A hint for anyone googling for this: make sure that the value of gcmSenderId in your AndroidManifest.xmlstill has the trailing backslash (\) after you’ve changed the project number to your own. Otherwise the value gets interpreted as int, when it should be a string, which is one way to trigger the issue of devices being assigned empty/null IDs.

(The building instructions do have this documented in bold, but it’s still very easy to miss, I know I did. Complicating the debugging was my Nexus 5X, which kept getting a proper device ID even when all other devices using the same broken build failed to.)

Vastaa viestiin sen kontekstissa (Github)

No rule to make target ’pre-buid’, needed by ’build-android’

19. lokakuuta 2018 klo 14.29
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Mattermost

The build-android target calls the pre-build target as pre-buid, resulting in build failure for the build-android target. This PR fixes the issue.

(PR #2272 did the same for a typo in the build-pr target.)

Vastaa viestiin sen kontekstissa (Github)

MPNS typos: notifications called ”notificaitons”

14. lokakuuta 2018 klo 19.00
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: kieli, Mattermost

The push proxy codebase refers to notifications as ”notificaitons” once in the README and once in a LogInfo() call.

Steps to reproduce

$ git clone https://github.com/mattermost/mattermost-push-proxy.git
$ cd mattermost-push-proxy/
$ git rev-parse HEAD
nothing to commit, working tree clean
$ git rev-parse HEAD
$ grep -Ri "notificaiton" .

Expected behavior

$ grep -Ri "notificaiton" .

Observed behavior (that appears unintentional)

$ grep -Ri "notificaiton" .
./server/android_notification_server.go:	LogInfo(fmt.Sprintf("Initializing Android notificaiton server for type=%v", me.AndroidPushSettings.Type))
./README.md:For more in-depth instructions on setting up push notificaitons with your own build please follow the directions at [docs.mattermost.com](https://docs.mattermost.com/developer/mobile-developer-setup.html#push-notifications-with-your-own-build)

Possible fixes

Here’s a link to the line in server/android_notification_server.go, README.md link unavailable because Github doesn’t allow per-line linking to Markdown files (that I know of). I think this should be pretty easy to fix and I can provide a pull request.

Vastaa viestiin sen kontekstissa (Github)

Add -f to all ps calls in Makefile

12. heinäkuuta 2018 klo 15.30
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Mattermost, Ubuntu

Output from procps’ ps with -e only produces the process name, so grepping for ”cli.js start” fails every time. This change adds (POSIX-compliant) -f to all ps calls to get the full command. AWK print parameter is adjusted accordingly where needed.

Issue #1359 resulted in PR #1370, but only addressed the stop: target. The changes here address the rest of the ps calls the same way.


Vastaa viestiin sen kontekstissa (Github)

« Uudempia - Vanhempia »