Avainsanana Mattermost

Missing builds of push proxy v5.25.0

19. syyskuuta 2023 klo 14.59
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Github, Mattermost

Summary

As of this writing, push proxy v5.25.0 was released 5 days ago, but the published assets on Github only include the source code.

Steps to reproduce

As per documentation,

wget https://github.com/mattermost/mattermost-push-proxy/releases/download/v5.25.0/mattermost-push-proxy.tar.gz

Expected behavior

Receive mattermost-push-proxy.tar.gz

Observed behavior (that appears unintentional)

404 Not Found

Vastaa viestiin sen kontekstissa (Github)

With 2.1 it always fails due to non-existent org.webrtc

24. helmikuuta 2023 klo 14.39
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Linux, Mattermost, Ubuntu

I have the same issue. I’m doing this in a Linux container (Ubuntu 20.04 inside Ubuntu 20.04), but like matthaios-easy-bi, I’m using npm run build:android to build (as per documentation). This has worked up until 2.0, but with 2.1 it always fails due to non-existent org.webrtc. Manually running npm install prior to npm run build:android makes no difference, nor does node node_modules/react-native-webrtc/tools/downloadWebRTC.js (although it does seemingly download the package successfully).

Here’s excerpts from the build output.

Vastaa viestiin sen kontekstissa (Github)

I have the same issue trying to compile v2.1.0 on my Linux PC

17. helmikuuta 2023 klo 13.43
Sijainti: Keskustelupalstat: Mattermost Discussion Forums
Avainsanat: Linux, Mattermost

It’s not Mac-only either, I have the same issue trying to compile v2.1.0 on my Linux PC.

V2.0 had issues too, but FTBFS wasn’t one of them.

Vastaa viestiin sen kontekstissa (Mattermost Discussion Forums)

Yes, it’s mainly about expectation

11. lokakuuta 2022 klo 19.47
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Mattermost

Hi @hmhealey,

Yes, it’s mainly about expectation. For an actual use case, I noticed this when mentioning an IRC channel name, which became a long, distracting and useless hashtag link, exacerbated by agglutination and multi-word hyphenation typical in Finnish, (e.g. #channelname-irc-kanavalla). I tried to make it less distracting by editing in a preceding backslash, only to discover that it didn’t work here.

Vastaa viestiin sen kontekstissa (Github)

No way to escape a word-starting hash character (#) in plaintext

11. lokakuuta 2022 klo 18.12
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Mattermost

Summary

There is no way to escape a word-starting hash character (#) in plaintext.

Steps to reproduce

In MM 7.3.0, post this, verbatim: \#anything

Expected behavior

#anything

Observed behavior (that appears unintentional)

#anything

Possible fixes

Workaround: instead of ”\#anything”, post this: &#​35;anything

Using backticks (`\#anything`) also works, but obviously the word then gets formatted as code and not plaintext.

Other notes

This is mainly an issue of inconsistency and surprise: backslash works to escape most other special formatting, so I’d expect it to work here too.

Vastaa viestiin sen kontekstissa (Github)

”Unlock increased productivity” spam

15. toukokuuta 2022 klo 15.42
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Mattermost

Summary

I’m getting these unrequested emails from my self-hosted instance, with no apparent way to disable them. This is bad, bad behavior.

Steps to reproduce

Host an instance running Mattermost 6.6.1. Leave it ”collecting a bit of dust”.

Expected behavior

Not to get spammed with unwanted emails.

Observed behavior (that appears unintentional)

Screenshot from 2022-05-15 15-35-12

Vastaa viestiin sen kontekstissa (Github)

Signing (public) key missing from Keybase

17. huhtikuuta 2022 klo 18.11
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Keybase, Mattermost

Summary

Keybase key for verifying the tar archive’s signature is missing.

Steps to reproduce

  1. try to download https://keybase.io/mattermost/key.asc

Expected behavior

Get a public key to verify the tar archive’s signature.

Observed behavior (that appears unintentional)

404 not found

Vastaa viestiin sen kontekstissa (Github)

auth login exits with status 0 even for a non-working URL

4. helmikuuta 2022 klo 11.14
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Mattermost

Steps to reproduce

Note the literal use of example.com here; don’t replace it with an actual, working MM instance URL.

# /usr/bin/sudo -u mattermost /usr/local/bin/mmctl  auth login http://example.com --name example --access-token 123456890abcdefghijklmnopq`
# echo $?

What I expect happen

For a non-zero exit status to be printed.

What happens instead

The exit status is 0.

Vastaa viestiin sen kontekstissa (Github)

–config with auth login only works correctly with ”config” as filename

30. tammikuuta 2022 klo 16.24
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Go, Mattermost

Issue

When a custom configuration file is supplied via --config to auth login, and reading credentials from the given file doesn’t succeed, an attempt is made to create the supplied directory path. This path is constructed by stripping a fixed ”config” (without a directory separator) from the user-supplied path.

When the custom configuration file doesn’t exist, this results in an unnecessary mkdir when the given filename ends with the hardcoded value of ”config” (case 1 below), or that plus a ”is a directory” failure when it doesn’t (case 2).

If the custom configuration file does exist, the useless mkdir is still triggered when the given filename ends with the hardcoded value of ”config” (case 3), or a ”not a directory” failure when it doesn’t (case 4).

Cause

The problematic mkdir call is issued here. I have no experience in Go, but instead of the TrimSuffix() call nested on that line, I think there should be a Go equivalent of a dirname instead, using the user-supplied path as parameter, and without referencing the value of configFileName (the source of the hardcoded ”config”).

Steps to reproduce

Case 1

A useless, empty mmctl_ directory gets created:

# rm -rf /tmp/mmctl_test/
# sudo -u mattermost mkdir /tmp/mmctl_test/
# /usr/bin/sudo -u mattermost /usr/local/bin/mmctl auth --quiet login https://example.com --name example --access-token 123456890abcdefghijklmnopq --config /tmp/mmctl_test/mmctl_config

  credentials for "example": "Personal Access Token@https://example.com" stored

# ls -lRa /tmp/mmctl_test/
/tmp/mmctl_test/:
yhteensä 24
drwxrwxr-x  3 mattermost mattermost  4096 tammi  30 15:27 .
drwxrwxrwt 23 root       root       12288 tammi  30 15:27 ..
drwx------  2 mattermost mattermost  4096 tammi  30 15:27 mmctl_
-rw-------  1 mattermost mattermost   244 tammi  30 15:27 mmctl_config

/tmp/mmctl_test/mmctl_:
yhteensä 8
drwx------ 2 mattermost mattermost 4096 tammi  30 15:27 .
drwxrwxr-x 3 mattermost mattermost 4096 tammi  30 15:27 ..

Case 2

Saving the credentials fails:

# rm -rf /tmp/mmctl_test/
# sudo -u mattermost mkdir /tmp/mmctl_test/
# /usr/bin/sudo -u mattermost /usr/local/bin/mmctl auth --quiet login https://example.com--name example --access-token 123456890abcdefghijklmnopq --config /tmp/mmctl_test/test
Error: cannot save the credentials: open /tmp/mmctl_test/test: is a directory
# ls -lRa /tmp/mmctl_test/
/tmp/mmctl_test/:
yhteensä 20
drwxrwxr-x  3 mattermost mattermost  4096 tammi  30 15:31 .
drwxrwxrwt 23 root       root       12288 tammi  30 15:31 ..
drwx------  2 mattermost mattermost  4096 tammi  30 15:31 test

/tmp/mmctl_test/test:
yhteensä 8
drwx------ 2 mattermost mattermost 4096 tammi  30 15:31 .
drwxrwxr-x 3 mattermost mattermost 4096 tammi  30 15:31 ..

Case 3

A useless, empty test_ directory is created:

# rm -rf /tmp/mmctl_test/
# sudo -u mattermost mkdir /tmp/mmctl_test/
# sudo -u mattermost touch /tmp/mmctl_test/test_config
# /usr/bin/sudo -u mattermost /usr/local/bin/mmctl auth login https://example.com --name example --access-token 123456890abcdefghijklmnopq --config /tmp/mmctl_test/test_config

  credentials for "example": "Personal Access Token@https://example.com" stored

# ls -lRa /tmp/mmctl_test/
/tmp/mmctl_test/:
yhteensä 24
drwxrwxr-x  3 mattermost mattermost  4096 tammi  30 15:58 .
drwxrwxrwt 22 root       root       12288 tammi  30 15:58 ..
drwx------  2 mattermost mattermost  4096 tammi  30 15:58 test_
-rw-rw-r--  1 mattermost mattermost   244 tammi  30 15:58 test_config

/tmp/mmctl_test/test_:
yhteensä 8
drwx------ 2 mattermost mattermost 4096 tammi  30 15:58 .
drwxrwxr-x 3 mattermost mattermost 4096 tammi  30 15:58 ..

Case 4

Saving the credentials again fails:

# rm -rf /tmp/mmctl_test/
# sudo -u mattermost mkdir /tmp/mmctl_test/
# sudo -u mattermost touch /tmp/mmctl_test/test
# /usr/bin/sudo -u mattermost /usr/local/bin/mmctl auth login https://example.com --name example --access-token 123456890abcdefghijklmnopq --config /tmp/mmctl_test/test
Error: mkdir /tmp/mmctl_test/test: not a directory
# ls -lRa /tmp/mmctl_test/
/tmp/mmctl_test/:
yhteensä 16
drwxrwxr-x  2 mattermost mattermost  4096 tammi  30 16:00 .
drwxrwxrwt 22 root       root       12288 tammi  30 16:00 ..
-rw-rw-r--  1 mattermost mattermost     0 tammi  30 16:00 test

Vastaa viestiin sen kontekstissa (Github)

–quiet not honored by auth login (possibly others)

30. tammikuuta 2022 klo 15.02
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Mattermost

Steps to reproduce

  1. Log in using mmctl.

What I expect to happen

# /usr/bin/sudo -u mattermost /usr/local/bin/mmctl --quiet auth login https://example.com --name example --access-token 123456890abcdefghijklmnopq
# 

What happens instead

# /usr/bin/sudo -u mattermost /usr/local/bin/mmctl --quiet auth login https://example.com --name example --access-token 123456890abcdefghijklmnopq

  credentials for "example": "Personal Access Token@https://example.com" stored

# 

Potential cause

From looking at the code, output and --quiet are implemented in Printer, but auth and a few other places appear to use fmt.Printf() directly instead.

Vastaa viestiin sen kontekstissa (Github)

Vanhempia »