Viestit paikassa Github

user_s_id translation missing, and redundant in update email template

18. heinäkuuta 2021 klo 15.53
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Brave, Crowdin, Gmail, iNaturalist, saavutettavuus

Describe the bug
The email with updates from the last 24 hours lists identifications, and mentions the name of the user having made the ID. The name is apparently supposed to be listed three times (!), but the middle occurrence is ”untranslated”, resulting in it being rendered as ”User S” for all identifications listed in the email.

Screenshot from 2021-07-18 14-58-03 (copy)

Tooltip text for the ”User S” string says ”translation missing: fi.user_s_id”, as I’m using the fi locale, but user_s_id is nowhere to be found in Crowdin, nor in current en.yml, so I suspect this is independent of the locale. The reference to user_s_id is in _update_email_activity.html.

I don’t know if this is doable, but after fixing this broken reference, I’d remove the first (header) mention of the identifier from the email altogether, since it’s followed by a listing of all the new identifiers anyway, so mentioning just the last identifier’s name in the header is redundant and confusing.

Also, rather than fixing/adding the currently broken ”User S” reference in the source, I’d remove it too, since the identifier’s name is already listed (for the third time!) right after the ID.

To Reproduce

  1. Subscibe to email updates.
  2. Have your observations identified in the last 24 hours.
  3. View the email update listing the identifications.

Observed behavior
Screenshot from 2021-07-18 15-21-05

Expected behavior
(A mockup of how the simplified view I’d prefer to receive. Sorry I didn’t have the email in English to base this on.)

Screenshot from 2021-07-18 15-21-05 (copy)

Context
I’m using Gmail with Brave if that’s relevant.

Vastaa viestiin sen kontekstissa (Github)

I’ve now rebased and pushed the changes, hope this works for you

2. kesäkuuta 2021 klo 22.13
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Github

@FlexW I’ve now rebased and pushed the changes, hope this works for you. I don’t see a way for me to merge this myself here, ”Only those with write access to this repository can merge pull requests.”

Vastaa viestiin sen kontekstissa (Github)

The terse explanation still seems pretty meaningless

28. toukokuuta 2021 klo 13.13
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Nextcloud, Ubuntu

I can add that to options.rst, but the terse explanation still seems pretty meaningless; at least for me there’s no visible difference when I run nextcloud with --background compared to running without.

This could be due to #2333 though, if running without --background is supposed to open the main dialog (which has never worked on Focal). If so, I’d mention this too, something like: ”Launch the application in the background (without opening the main dialog).”

Vastaa viestiin sen kontekstissa (Github)

Not really, as I don’t know what the parameter does… due to it being undocumented :)

27. toukokuuta 2021 klo 18.12
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Nextcloud

@FlexW Not really, as I don’t know what the parameter does… due to it being undocumented :) Editing options.rst shouldn’t be an issue, I’d just need to know what it should say about --background.

Vastaa viestiin sen kontekstissa (Github)

No documentation for –background

27. toukokuuta 2021 klo 15.53
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Nextcloud

Preface

Ticking the ”Launch on System Startup” box in the desktop client’s General settings tab (correctly) adds a .desktop file under ~/.config/autostart/, with the following Exec line:

    Exec="/usr/bin/nextcloud" --background

Expected behaviour

The effect of --background should be mentioned in options.rst (and the resulting online documentation).

Actual behaviour

The --background parameter is undocumented.

Client configuration

Client version: 3.2.1
Operating system: Ubuntu 20.04
OS language: English
Client package: 3.2.1-20210429.171749.5901a0f98-1.0~focal1

Vastaa viestiin sen kontekstissa (Github)

No backup/recovery code mechanism for MFA

10. toukokuuta 2021 klo 17.28
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Mattermost, security

Summary

After setting up multi-factor authentication, losing the authentication code-generating device means losing access to the Mattermost account. While having MFA is excellent, I’m afraid to set it up for my admin user account (which is the one most critically needing it), because there’s no recovery mechanism in case I lose my authenticator device.

Steps to reproduce

  1. Enable up multi-factor authentication in the System Console
  2. Configure 2FA with an authenticator app on your phone
  3. Break/lose/have your phone stolen
  4. Try to log in

Expected behavior

Have a ”use a backup code instead” link next to the MFA token prompt.

Observed behavior (that appears unintentional)

There’s no alternative way to provide the MFA. You can not log in.

Possible fixes

None available AFAICT. There’s no way to add security keys as alternatives either.

There’s an existing Jira ticket ticket about this (and it’s linked to an abandoned PR), but it’s closed as ”moved to ProductBoard for prioritization”, and I don’t know what’s happened since then, as I don’t have access to ProductBoard (that I know of).

Mattermost version

v5.34.2

Vastaa viestiin sen kontekstissa (Github)

indent/outdent mismatch when using multi-line array assignment inside case…esac

4. toukokuuta 2021 klo 12.13
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Bash

My go-to way of quickly parsing arguments is as follows:

#!/bin/bash                                                                  
                                                                             
quiet="true"                                                                 
files=()                                                                     
                                                                             
for arg in "${@}"; do                                                        
    case "${arg}" in                                                         
        "-v" | "--verbose")                                                  
            quiet="false"                                                    
            ;;                                                               
        *)
            files+=(                                                         
                "${arg}"                                                     
            )                                                                   
            ;;                                                               
    esac                                                                     
done                                                                         

Beautysh (v6.1.0) incorrectly reports this as indent/outdent mismatch and instead indents it like so:

#!/bin/bash                                                                  
                                                                             
quiet="true"                                                                 
files=()                                                                     
                                                                             
for arg in "${@}"; do                                                        
    case "${arg}" in                                                         
        "-v" | "--verbose")                                                  
            quiet="false"                                                    
            ;;                                                               
        *)                                                                   
            files+=(                                                         
                "${arg}"                                                     
            )                                                                
                ;;                                                           
        esac                                                                 
    done

The deciding factor seems to be the multi-line parenthesis in assigning files. If I assign it all on one line, like this:

            files+=("${arg}")                                                

then beautysh is satisfied with the indentation (i.e. doesn’t change it or report a mismatch).

Vastaa viestiin sen kontekstissa (Github)

Android 7.1.2 (LineageOS 14.1) is affected

11. maaliskuuta 2021 klo 18.37
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Android, LineageOS

Android 7.1.2 (LineageOS 14.1) is affected.

Vastaa viestiin sen kontekstissa (Github)

Nextcloud is somehow different from other apps in this regard

6. helmikuuta 2021 klo 13.08
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Android, Nextcloud

Nextcloud is somehow different from other apps in this regard, as no other light (white) apps on the same device have this issue. For instance, here’s Play Store on my affected device (running Android 6.0.1):

Screenshot_20210206-124828

Also, I seem to recall this only having started to affect Nextcloud quite recently, perhaps sometime in the past month or so.

Switching to dark mode is a workaround on my device at least (there the Android buttons are light-on-black). I can also confirm that the issue doesn’t affect my newer devices with newer Android.

Vastaa viestiin sen kontekstissa (Github)

I see, so it’s a result of conflicting indicators from the user

19. joulukuuta 2020 klo 18.41
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Mattermost, saavutettavuus

@agnivade Oh I see, so it’s a result of conflicting indicators (”away” vs. being active) from the user. I’m trying to recalibrate my expectation based on this, but it’s difficult.

My immediate thought is perhaps (in the problematic case) sending the notification, but then clearing it only once I start typing (typing appears to have an event associated with it, at least based on the logs) would be better than the immediately clearing ghost notification, but you’re right, this is more complicated than immediately apparent.

Some UI/UX design wizardry would probably be needed to eliminate the possibility of mixed user signals, if at all possible. I don’t have a good solution for now, so feel free to close the issue if you deem it appropriate.

Vastaa viestiin sen kontekstissa (Github)

Vanhempia »