Amended to replace whitespaces mixed with tabs in extension.json, and to fix description message id.

Refactor file structure so that the extension can be loaded using MW 1.25+ style wfLoadExtension(), and makes MW 1.25+ a requirement. Otherwise the core functionality should remain just as it was (i.e., if it doesn’t, that’s unintentional on my part).

This closes issue #3.

Since MediaWiki 1.25, the suggested method of registering extensions has been to use wfLoadExtension() instead of a direct require_once. AddBodyClass currently (v1.2.0 from 2016-03-21) still uses the old style, so I’m opening this issue to suggest converting the extension to use the new method.

I’m also preparing a pull request with the minimal changes that I think should accomplish this, and I’ll post it next.

This happens in 18.04 too. Bug #1650076 does also, and I’m not 100 % sure if these are two different issues or the same. I was able to reproduce #1650076 with the steps listed there, but just before that I had Evince following my scroll wheel despite being unfocussed, and I had not selected anything in the PDF before that (at least not knowingly). I haven’t found the steps to reproduce this without the selection though.

When acpica-tools is not installed, running acpidump or acpixtract produces no suggestions (in either Bionic or Cosmic):

$ acpixtract
acpixtract: command not found
$ apt-cache policy acpitools-ca
N: Unable to locate package acpitools-ca
$ apt-cache policy acpica-tools
acpica-tools:
Installed: (none)
Candidate: 20180629-1
Version table:
20180629-1 500
500 http://archive.ubuntu.com/ubuntu cosmic/universe amd64 Packages
$ sudo apt install acpica-tools
[sudo] password for jani:
Reading package lists… Done
Building dependency tree
Reading state information… Done
The following packages were automatically installed and are no longer required:
linux-headers-4.18.0-8 linux-headers-4.18.0-8-generic linux-image-4.18.0-8-generic linux-modules-4.18.0-8-generic
linux-modules-extra-4.18.0-8-generic
Use ’sudo apt autoremove’ to remove them.
The following NEW packages will be installed:
acpica-tools
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 851 kB of archives.
After this operation, 2782 kB of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu cosmic/universe amd64 acpica-tools amd64 20180629-1 [851 kB]
Fetched 851 kB in 1s (1622 kB/s)
Selecting previously unselected package acpica-tools.
(Reading database … 207563 files and directories currently installed.)
Preparing to unpack …/acpica-tools_20180629-1_amd64.deb …
Unpacking acpica-tools (20180629-1) …
Setting up acpica-tools (20180629-1) …
update-alternatives: using /usr/bin/acpixtract-acpica to provide /usr/bin/acpixtract (acpixtract) in auto mode
update-alternatives: warning: skip creation of /usr/share/man/man1/acpixtract.1.gz because associated file /usr/share/man/man1/acpixtract-acpica.1 (of link group acpixtract) doesn’t exist
update-alternatives: using /usr/bin/acpidump-acpica to provide /usr/bin/acpidump (acpidump) in auto mode
update-alternatives: warning: skip creation of /usr/share/man/man1/acpidump.1.gz because associated file /usr/share/man/man1/acpidump-acpica.1 (of link group acpidump) doesn’t exist
Processing triggers for man-db (2.8.4-2) …
$ acpidump
Could not open table file: /sys/firmware/acpi/tables/SSDT
Could not get ACPI tables, AE_ACCESS
$ acpixtract

Intel ACPI Component Architecture
ACPI Binary Table Extraction Utility version 20180629
Copyright (c) 2000 – 2018 Intel Corporation

Usage: acpixtract [option] <InputFile>
Options:
-a Extract all tables, not just DSDT/SSDT
-f Force extraction, even if there are errors
-l List table summaries, do not extract
-m Extract multiple DSDT/SSDTs to a single file
-s <signature> Extract all tables with <signature>
-v Display version information
-vd Display build date and time

Extract binary ACPI tables from text acpidump output
Default invocation extracts the DSDT and all SSDTs

Here’s a small patch to fix the spelling of comparative + than, which is currently misspelled as comparative + then in a couple of places.

Not sure if this URL is supported, but the error message doesn’t look quite right, nor clear as to what the problem is from a user’s perspective:

$ yle-dl 'https://yle.fi/aihe/artikkeli/2013/04/11/aanien-illoissa-kuunnellaan-kadonneitakin-aania'
yle-dl 2.37: Download media files from Yle Areena and Elävä Arkisto
Copyright (C) 2009-2018 Antti Ajanki <antti.ajanki@iki.fi>, license: GPLv3

Traceback (most recent call last):
  File "/usr/local/bin/yle-dl", line 11, in <module>
    load_entry_point('yle-dl==2.37', 'console_scripts', 'yle-dl')()
  File "build/bdist.linux-x86_64/egg/yledl/yledl.py", line 377, in main
  File "build/bdist.linux-x86_64/egg/yledl/yledl.py", line 252, in download
  File "build/bdist.linux-x86_64/egg/yledl/extractors.py", line 543, in extract
  File "build/bdist.linux-x86_64/egg/yledl/extractors.py", line 736, in extract_clip
  File "build/bdist.linux-x86_64/egg/yledl/extractors.py", line 983, in program_info_for_pid
  File "build/bdist.linux-x86_64/egg/yledl/extractors.py", line 791, in media_flavors
  File "build/bdist.linux-x86_64/egg/yledl/extractors.py", line 875, in download_flavors
  File "build/bdist.linux-x86_64/egg/yledl/backends.py", line 499, in __init__
  File "build/bdist.linux-x86_64/egg/yledl/backends.py", line 40, in __init__
AttributeError: 'NoneType' object has no attribute 'startswith'

I made a note about the failure in my kanban (yesterday) at ”13:17:10 GMT+0300 (EEST)”, so that would have been 10:17:10 UTC.

Thanks for the excellent plugin! I’ve only had one issue so far: the previews are apparently saved encoded, which makes any decoded preview content unsearchable with WordPress’ search function (whereas searching for a piece of the encoded string brings up the matching post). If you could implement searchability of the decoded content, that’d be great.

I’m seeing memory-related crashes when playing videos sliced (with ffmpeg -c copy) from mp4 streams (downloaded with youtube-dl). I’m attaching a sample clip which, granted, is pretty useless for a video, but which produces these crashes with 100% certainty for me; I just edited it down to a reasonable size and non-infringing content.

The errors reported just before core is dumped are (mostly) ”double free or corruption (fasttop)” or (less often) ”malloc_consolidate(): invalid chunk size”.

To be clear, my expectation here is not for the problematic clips to have useful content, or even to play back; just that vlc didn’t crash. (Totem for instance does not seem to crash with the same files.)

I’ll attach logs for both the double free and malloc_consolidate cases (which I’m producing by running LC_ALL=C vlc -vvv out.mp4 in a loop).