user_s_id translation missing, and redundant in update email template

18. heinäkuuta 2021 klo 15.53
Sijainti: Vianhallintajärjestelmät: iNaturalist
Avainsanat: Brave, Gmail, saavutettavuus

Describe the bug
The email with updates from the last 24 hours lists identifications, and mentions the name of the user having made the ID. The name is apparently supposed to be listed three times (!), but the middle occurrence is ”untranslated”, resulting in it being rendered as ”User S” for all identifications listed in the email.

Screenshot from 2021-07-18 14-58-03 (copy)

Tooltip text for the ”User S” string says ”translation missing: fi.user_s_id”, as I’m using the fi locale, but user_s_id is nowhere to be found in Crowdin, nor in current en.yml, so I suspect this is independent of the locale. The reference to user_s_id is in _update_email_activity.html.

I don’t know if this is doable, but after fixing this broken reference, I’d remove the first (header) mention of the identifier from the email altogether, since it’s followed by a listing of all the new identifiers anyway, so mentioning just the last identifier’s name in the header is redundant and confusing.

Also, rather than fixing/adding the currently broken ”User S” reference in the source, I’d remove it too, since the identifier’s name is already listed (for the third time!) right after the ID.

To Reproduce

  1. Subscibe to email updates.
  2. Have your observations identified in the last 24 hours.
  3. View the email update listing the identifications.

Observed behavior
Screenshot from 2021-07-18 15-21-05

Expected behavior
(A mockup of how the simplified view I’d prefer to receive. Sorry I didn’t have the email in English to base this on.)

Screenshot from 2021-07-18 15-21-05 (copy)

Context
I’m using Gmail with Brave if that’s relevant.

Vastaa viestiin sen kontekstissa (iNaturalist)