The trailing <span class="__iawmlf-post-loop-links"> element introduced in PR #338 causes WordPress to render a trailing newline as a <br /> tag in the last paragraph. This behavior differs from when Link Fixer is not active.
I don’t know if the block editor is affected, since I don’t use it, but the issue is present when using the Classic Editor, and even there you have to use the Code view (because Visual view either converts the trailing newline into a line with an , or strips the trailing newline when switching to Code view).
My guess is that this is wpautop trying to be smart about the content, seeing the trailing <span> from Link Fixer, and thinking it’s visible content, so the trailing newline in the actual content (as entered in the editor) should be rendered as a visible <br /> too.
This is probably a very niche issue, and I’m sure I can figure out a way to work around it, but I wanted to document it anyway.
Steps to reproduce
- deactivate Link Fixer
- use Classic Editor’s Code view to create a post
- end the final paragraph with a newline
preview publish the post and inspect the last paragraph: there is no newline before the closing </p> tag
- activate Link Fixer
- create another post with the same contents
preview publish the post and inspect the last paragraph
What you expected to happen
the <span> to immediately follow the last word and immediately precede the closing </p> tag, with no newline before or after
What actually happened
the <span> is separated from the last word with a <br /> tag followed by a plain newline
I fired up 152.0a1 (from nightly), did my steps above, and could no longer reproduce the issue. So it does seem to be fixed!
I know I’m not the one the request was directed to, but I’ve attached my log anyway. What I did to produce it:
1. MOZ_LOG="WidgetScreen:5,WidgetWayland:5,Widget:5,WidgetPopup:5" /usr/bin/firefox >log.txt 2>&1
2. opened the Wikipedia article for Firefox
3. powered off both my monitors, then powered them back on
4. tried right-clicking many of the links on the page
5. quit Firefox
Reproducible for me in Ubuntu 24.04, Firefox 150.0 from Mozilla’s PPA, with a small difference: new tab button does seem to work, which is useful, since without it wouldn’t be possible to open about:config the workaround of toggling widget.wayland.fractional-scale.enabled.
A small addition: Firefox 150.0 (from Mozilla’s PPA) is similarly affected for me, so this is indeed an upstream one.
This looks like #2851 on the COSMIC issue tracker, affecting Firefox. They’ve also reported it upstream.
The COSMIC issue has been closed as having been fixed by 150.0, but there’s at least one dissenter.
Anyway, I’m using a regular Gnome desktop on Ubuntu 24.04, with Wayland, Librewolf 150.0, and funnily enough, for me this only appeared with 150.0 and not before. So now I am affected.
The workaround of toggling widget.wayland.fractional-scale.enabled mentioned in the COSMIC issue seems to work (i.e. after the menus have died, open about:config, toggle the setting from default trueto false, then immediately back to true).
Using a supported version?
- I have searched open and closed issues for duplicates.
- I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.
Overall summary
I’ve set notes to self to disappear after 1 day. I chose one message to be pinned, was prompted to select the time to pin the message for, and selected 7 days. I was shown the message in the title.
I’m now unsure whether the message will be unpinned and removed after 1 day or 7 days. My guess would be 7 days, but either way, I think the message should make this explicit, or at least unambiguous wrt. which timer takes precedence.
Steps to reproduce
- set notes to self to disappear after 1 day
- send a note to yourself
- choose to pin the message
- select to pin the message for 7 days
Expected result
Any of these, in order of preference:
- ”This disappearing message will be unpinned and removed from the chat after 7 days.”
- ”This disappearing message will be unpinned and removed from the chat after 1 day.”
- ”Disappearing messages will be unpinned and the removed from the chat when the pinning timer expires.”
- ”Disappearing messages will be unpinned and the removed from the chat when the disappearance timer expires.”
Actual result
”Disappearing messages will be unpinned when their timer expires and the message is removed from the chat.”
Screenshots
No response
Signal version
8.7.0
Operating system
Ubuntu 24.04
Version of Signal on your phone
8.6
No worries, thanks for the fix!
Both issues (”Network is unreachable” and WoL not working) were fixed for me after the latest kernel update, which was Linux 6.8.0-106.
Yeah, seems to be fixed: I tested in an Ubuntu 24.04 vm with WezTerm 20240203-110809-5046fc22 and couldn’t reproduce the issue.
(I first tried the nightly, which from the repository was 20260117-154428-05343b38, but that one was missing all window decorations entirely, and so couldn’t be resized at all.)
I’ll close the issue and unsubscribe, as I’m not using WezTerm currently myself. Others can reopen it if still affected.