Impacted version: 0.38

Server Setup Information:

• Operating System: Ubuntu 16.04
• Deployment Method: snap

snap info wekan reports snap-id as jtpboSYvTCEyHoutkkRo1SI9ioSMOUb3 (tracking: stable). I’m not sure how to find out Node and MongoDB versions from the snap, but if the snap ID isn’t enough, just show me how to get those version numbers and I’ll add them.

• ROOT_URL environment variable (Is there a subfolder?): reproducible both with (https://my-domain.com/kan) and without subdirectory (http://localhost:5000 inside a VM).

Steps to reproduce:

1. Create a board in Trello.
2. Create a list in the board.
3. Create a card in the list.
4. Create a checklist in the card.
5. Export the board as JSON.
6. In Wekan, initiate a Trello import.
7. Map the user.

What I expect to happen:
For the board to be imported in Wekan.

What happens:
The importer reports a ’400’. journalctl -u snap.wekan.wekan.service reports

Exception while invoking method 'importBoard' Error: Sort is required
     at getErrorObject (packages/aldeed_collection2-core.js:480:15)
     at [object Object].doValidate (packages/aldeed_collection2-core.js:462:13)
     at [object Object].Mongo.Collection.(anonymous function) [as insert] (packag
     at packages/matb33_collection-hooks.js:127:46
     at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
     at Object.directOp (packages/matb33_collection-hooks.js:47:27)
     at Object.self.direct.(anonymous function) [as insert] (packages/matb33_coll
     at models/trelloCreator.js:407:45
     at Array.forEach (native)
     at TrelloCreator.createChecklists (models/trelloCreator.js:400:22)
     at TrelloCreator.create (models/trelloCreator.js:606:10)
     at [object Object].Meteor.methods.importBoard (models/import.js:27:20)
     at packages/check.js:130:16
     at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
     at Object.exports.Match._failIfArgumentsAreNotAllChecked (packages/check.js:
     at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1734:18)
Sanitized and reported to the client as: Sort is required [400]

I’m attaching the failing JSON (with email sanitized).

With Gitlab 9.5.4-ce.0 and Apache 2.4.18, I had to set `DirectoryIndex disabled` for the Gitlab directory (in the vhost configuration) to fix this when using RewriteRules. (I’ve now switched to using ProxyPass instead.)

Steps to reproduce

Add an image to a post, type in a caption and set alignment to ’None’.

What I expect to happen

I’d expect the captioned image to be left-aligned with the main content column’s left, in line with <p>elements.

What happens

The image is left-aligned to the left edge of the screen. My attachment is a screenshot of a post with one uncaptioned and one captioned alignnone image.

== Steps to reproduce ==
1. Download https://upload.wikimedia.org/wikipedia/commons/thumb/e/e1/Car_crash_1.jpg/193px-Car_crash_1.jpg?download
2. Open the image in Shotwell Viewer: $ shotwell 193px-Car_crash_1.jpg
3. Select File > Save As…
4. Select OK (without changing Format from ”Current”, or any other parameters)
5. Enter ”193px-Car_crash_1.png” (without quotes) as the filename, select OK

== What happens ==
The viewer now displays a black screen, with the text ”Photo source file missing:” followed by the (.png-ending) image path entered in the dialog. The file has not been saved.

== What I expect to happen ==
For the (now misnamed) .png-ending file to have been saved, and be opened in the Viewer.

== Other notes ==
* If a file with the .png ending already exists, and I try overwriting it with the JPEG, the black error screen does not appear, and the viewer appears as if it had saved the file. But the file hasn’t actually been saved; if 193px-Car_crash_1.png was an empty file before seemingly overwriting it, it remains empty.
* I’m (intentionally) not doing an actual Format change in the first Save As dialog here. If I do select PNG as the format, then saving the file does work as expected (using any filename extension).
* I used .png just as an example here. Any variant of /jpe?g/i as the extension seems to work as expected, whereas anything else (.gif, .foo etc.) results in the same ”file missing” error as above.
* If the original file is a PNG file, saving it with .jpg (or any other extension for that matter) seems to work as expected.

== Background ==

Reporting from Xenial, but this is currently reproducible in Artsy too.

$ locale
LANG=fi_FI.UTF-8
LANGUAGE=fi:en
LC_CTYPE=fi_FI.UTF-8
LC_NUMERIC=”fi_FI.UTF-8″
LC_TIME=”fi_FI.UTF-8″
LC_COLLATE=fi_FI.UTF-8
LC_MONETARY=”fi_FI.UTF-8″
LC_MESSAGES=fi_FI.UTF-8
LC_PAPER=”fi_FI.UTF-8″
LC_NAME=”fi_FI.UTF-8″
LC_ADDRESS=”fi_FI.UTF-8″
LC_TELEPHONE=”fi_FI.UTF-8″
LC_MEASUREMENT=”fi_FI.UTF-8″
LC_IDENTIFICATION=”fi_FI.UTF-8″
LC_ALL=

== Test case ==

$ git init test
$ cd test
$ echo ”foo” > bär
$ git add [hit tab key]
$ git add \”b\\303\\244r\” [hit enter]

== What happens ==

fatal: pathspec ’”b\303\244r”’ did not match any files

== What I expect to happen ==

For the filename to be correctly completed, like with ls:

$ mkdir test2
$ cd test2
$ echo ”foo” > bär
$ ls [hit tab key]
$ ls bär [hit enter]
bär

For optimizing files in-place with jpegtran, especially from scripts and when dealing with lots of pictures, it’s handy to be able to specify input file as -outfile.

But there’s a catch:

Steps to reproduce:
0. Have a large JPEG file, or, alternatively, somewhat slow CPU
1. `jpegtran -optimize -copy all -perfect -outfile large.jpg large.jpg`
2. Hit Ctrl-C before the command finishes

Result:
You now have a broken large.jpg with only part, if any, of the image data remaining.

What I expect to happen:
To have large.jpg as it was before I invoked jpegtran.

Workarounds:
Obviously the traditional workaround of specifying an intermediate temporary output file, then replacing the original with the temporary file only once jpegtran has finished.

Depending on use case, using `fmt -w 80` instead of fold may do for a workaround.

Technical details

• YOURLS version: master (at e36ec69)
• PHP version: 5.6.30
• I’m running Yourls on shared hosting and they have php5-geoip installed

Bug Summary

After pulling recent changes (up to e36ec69) today, I’ve hit what appears to be a regression of issue #359: I get a blank page and a ”Cannot redeclare geoip_country_code_by_name()” (in includes/geo/geoip.inc on line 1602) error in my log.

I can work around the issue by checking out d5a5522, which is the last commit prior to ”Update GeoIP” (96a159b).

I make no guarantees this doesn’t break something else, but for me it seems to work correctly if I make Feediron_Json::format() skip carriage returns:

$ git diff
diff --git a/Json.php b/Json.php
index c988962..fc7f554 100644
--- a/Json.php
+++ b/Json.php
@@ -8,6 +8,7 @@ class Feediron_Json{
                $strLen      = strlen($json);
                $indentStr   = '    ';
                $newLine     = "\n";
+               $cReturn     = "\r";
                $prevChar    = '';
                $outOfQuotes = true;
                $currentline = 0;
@@ -30,6 +31,9 @@ class Feediron_Json{
                                $currentline++;
                                continue;
                        }
+                       if($char == $cReturn){
+                               continue;
+                       }
                        if($char == ' ' && $outOfQuotes){
                                continue;
                        }

(Using PHP 5.6.30 here.)

@davesteele Yup, installs without a hitch now. Much appreciated!