Having shot myself in the foot by rewriting already pushed history, it occurred to me that perhaps I could have the commits list in interactive rebase reflect the commits’ push status in color. If lines of commits that I’ve already pushed to a remote were colored red (or any sufficiently differentiating color), I might actually notice when I’m about to screw up again.
To illustrate what I mean, here’s a mockup I made. This is what it would look like if this was my commit history, and 8b0ce7b was the last commit I had already pushed to a remote:
I have no previous experience in modifying syntax highlighting code, and I have no idea if what I’m suggesting is even possible with vim, so I figured I’d open this request first in case it’s a silly idea, or conversely, if you deem this useful enough to implement yourself.
== Background ==
Reporting from Xenial, but this is currently reproducible in Artsy too.
$ locale
LANG=fi_FI.UTF-8
LANGUAGE=fi:en
LC_CTYPE=fi_FI.UTF-8
LC_NUMERIC=”fi_FI.UTF-8″
LC_TIME=”fi_FI.UTF-8″
LC_COLLATE=fi_FI.UTF-8
LC_MONETARY=”fi_FI.UTF-8″
LC_MESSAGES=fi_FI.UTF-8
LC_PAPER=”fi_FI.UTF-8″
LC_NAME=”fi_FI.UTF-8″
LC_ADDRESS=”fi_FI.UTF-8″
LC_TELEPHONE=”fi_FI.UTF-8″
LC_MEASUREMENT=”fi_FI.UTF-8″
LC_IDENTIFICATION=”fi_FI.UTF-8″
LC_ALL=
== Test case ==
$ git init test
$ cd test
$ echo ”foo” > bär
$ git add [hit tab key]
$ git add \”b\\303\\244r\” [hit enter]
== What happens ==
fatal: pathspec ’”b\303\244r”’ did not match any files
== What I expect to happen ==
For the filename to be correctly completed, like with ls:
$ mkdir test2
$ cd test2
$ echo ”foo” > bär
$ ls [hit tab key]
$ ls bär [hit enter]
bär
Technical details
- YOURLS version: master (at e36ec69)
- PHP version: 5.6.30
- I’m running Yourls on shared hosting and they have php5-geoip installed
Bug Summary
After pulling recent changes (up to e36ec69) today, I’ve hit what appears to be a regression of issue #359: I get a blank page and a ”Cannot redeclare geoip_country_code_by_name()” (in includes/geo/geoip.inc on line 1602) error in my log.
I can work around the issue by checking out d5a5522, which is the last commit prior to ”Update GeoIP” (96a159b).
Sumana: Thanks. I’m fairly new here and to Git in general, so I’d rather not, but it’s fine by me if Pranav wants to.
