Avainsanana Mattermost

MPNS typos: notifications called ”notificaitons”

14. lokakuuta 2018 klo 19.00
Sijainti: Vianhallintajärjestelmät: kieli
Avainsanat: Mattermost

The push proxy codebase refers to notifications as ”notificaitons” once in the README and once in a LogInfo() call.

Steps to reproduce

$ git clone https://github.com/mattermost/mattermost-push-proxy.git
$ cd mattermost-push-proxy/
$ git rev-parse HEAD
41affc6595fc927a75de1184292cec89278b40a8
nothing to commit, working tree clean
$ git rev-parse HEAD
41affc6595fc927a75de1184292cec89278b40a8
$ grep -Ri "notificaiton" .

Expected behavior

$ grep -Ri "notificaiton" .
$

Observed behavior (that appears unintentional)

$ grep -Ri "notificaiton" .
./server/android_notification_server.go:	LogInfo(fmt.Sprintf("Initializing Android notificaiton server for type=%v", me.AndroidPushSettings.Type))
./README.md:For more in-depth instructions on setting up push notificaitons with your own build please follow the directions at [docs.mattermost.com](https://docs.mattermost.com/developer/mobile-developer-setup.html#push-notifications-with-your-own-build)

Possible fixes

Here’s a link to the line in server/android_notification_server.go, README.md link unavailable because Github doesn’t allow per-line linking to Markdown files (that I know of). I think this should be pretty easy to fix and I can provide a pull request.

Vastaa viestiin sen kontekstissa (kieli)

Add -f to all ps calls in Makefile

12. heinäkuuta 2018 klo 15.30
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Mattermost, Ubuntu

Output from procps’ ps with -e only produces the process name, so grepping for ”cli.js start” fails every time. This change adds (POSIX-compliant) -f to all ps calls to get the full command. AWK print parameter is adjusted accordingly where needed.

Issue #1359 resulted in PR #1370, but only addressed the stop: target. The changes here address the rest of the ps calls the same way.

 

Vastaa viestiin sen kontekstissa (Github)

Reproducible here on a Galaxy Tab 4 (SM-T530), Android 5.0.2.

16. lokakuuta 2017 klo 20.26
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Android, Mattermost, Samsung

Reproducible here on a Galaxy Tab 4 (SM-T530), Android 5.0.2.

Vastaa viestiin sen kontekstissa (Github)

« Uudempia