Yes, this is still reproducible here with the current server (v5.29.1).
Here’s the server log and MPNS log during which
1.37.0 fails to build in my build environment (Ubuntu 18.04 in LXC) with this error:
ubuntu@mattermost-mobile:~/mattermost-mobile$ npm run build:android
> mattermost-mobile@1.37.0 build:android /home/ubuntu/mattermost-mobile
> ./scripts/build.sh apk
./scripts/build.sh: 3: ./scripts/build.sh: Syntax error: "(" unexpected
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! mattermost-mobile@1.37.0 build:android: `./scripts/build.sh apk`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the mattermost-mobile@1.37.0 build:android script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/ubuntu/.npm/_logs/2020-11-14T11_47_00_288Z-debug.log
The top of that file, build.sh, refers to /bin/sh, but on Ubuntu and Debian, /bin/sh has been Dash for quite a while, whereas build.sh seems to written for Bash (where function is a valid keyword):
ubuntu@mattermost-mobile:~/mattermost-mobile$ head scripts/build.sh
#!/bin/sh
function execute() {
cd fastlane && NODE_ENV=production bundle exec fastlane $1 $2
}
I suggest switching the shebang to #/bin/bash, or better yet, #!/usr/bin/env bash (for path-agnosticity). In my environment, using either one fixes the build.
This hasn’t manifested itself in ages anymore, so it’s probably fixed.
Mobile devices receive ”ghost” notifications for already read messages, when set to receive notifications ”when Away or offline”, and receiving user is set to be Away.
Nothing happens on the mobile device (no notification).
The mobile device receives a notification about the already read message. The notification immediately disappears. If you weren’t looking at the device, you’re left wondering why it alerted you.
If your status is set to Online instead of Away (at step 2), the mobile device receives no notification (as expected). If ”Trigger push notifications when” is set to ”Online, away or offline” (at step 1), the mobile device receives no notification irrespective of your Online/Away status (also as expected).
I’m self-hosting Mattermost 5.26.1 with self-hosted MMPNS 5.22.4. Mattermost Mobile is at version 1.34.0. My mobile devices have Android 10 (Samsung) and Android 7.1.2 (LineageOS 14.1).
I don’t know if this is an issue with the client or the server; I can re-report against the latter if appropriate.
@amyblais No subpath, just the plain domain.
Hi @amyblais, thanks for taking a look!
Here are the banner settings:
# grep -i banner config.json
"EnablePreviewModeBanner": true,
"EnableBanner": false,
"BannerText": "",
"BannerColor": "#f2a93b",
"BannerTextColor": "#333333",
"AllowBannerDismissal": true
I should also mention that I’ve previously enabled Developer Mode ("EnableDeveloper": true), but I’m not sure it’s related, since the notification in this issue has the normal blue background, not a purple one.
The issue reappeared today for the other affected user, then kept disappearing and reappearing under testing, but we were unable to pin down any specific reason. Their browser console (Firefox) only has this:
websocket connecting to wss://[redacted]/api/v4/websocket websocket_client.jsx:35:20
and the server log meanwhile only has this line repeated:
mlog/log.go:174 {"name":"TypeError","message":"NetworkError when attempting to fetch resource.","stack":""} {"path": "/api/v4/logs", "request_id": "g8wwo8yu57djmkipjxjxn7hy3y", "ip_addr": "[redacted]", "user_id": "[redacted]", "method": "POST", "err_where": "client", "http_code": 0, "err_details": ""}
(where user_id is the one for the affected user.)
Selecting the ”Refresh the app now” link from update notification doesn’t make the notification go away.
Have MM server updated to latest release. Open an existing session of the web app in Firefox. See the refresh prompt, select ”Refresh the app now”.
Web page is refreshed, the notification goes away.
Web page is refreshed, but the update notification is still there, still prompting to refresh.
With some of the most recent updates (perhaps 5.16 and newer), the ”Refresh the app now” link in the update notification (”A new version of Mattermost is available”) on the web app did not make that notification go away for myself and another user. The link did cause a refresh of the page content, but the notification persisted. Meanwhile the version being reported by ”About Mattermost” was the correct (5.16.2).
Ctrl+shift+r or other hard refresh attempts did not have an effect, but logging out and then back in to the site finally did make the notification go away.
We’re both Firefox users, and due to the nature of the issue it was difficult to tell if this was browser-specific, but a fresh login using Chrome (while the previous session in Firefox still showed the notification) did not bring up the notification in the new session.
The issue, though irritatingly persistent while it lasted, was still relatively ephemeral, and now that it’s gone, I wouldn’t know how to reproduce it before the next server update. That said, I’ll happily provide more details if I can.
A hint for anyone googling for this: make sure that the value of gcmSenderId in your AndroidManifest.xmlstill has the trailing backslash (\) after you’ve changed the project number to your own. Otherwise the value gets interpreted as int, when it should be a string, which is one way to trigger the issue of devices being assigned empty/null IDs.
(The building instructions do have this documented in bold, but it’s still very easy to miss, I know I did. Complicating the debugging was my Nexus 5X, which kept getting a proper device ID even when all other devices using the same broken build failed to.)
The build-android target calls the pre-build target as pre-buid, resulting in build failure for the build-android target. This PR fixes the issue.
(PR #2272 did the same for a typo in the build-pr target.)
The push proxy codebase refers to notifications as ”notificaitons” once in the README and once in a LogInfo() call.
$ git clone https://github.com/mattermost/mattermost-push-proxy.git
$ cd mattermost-push-proxy/
$ git rev-parse HEAD
41affc6595fc927a75de1184292cec89278b40a8
nothing to commit, working tree clean
$ git rev-parse HEAD
41affc6595fc927a75de1184292cec89278b40a8
$ grep -Ri "notificaiton" .
$ grep -Ri "notificaiton" .
$
$ grep -Ri "notificaiton" .
./server/android_notification_server.go: LogInfo(fmt.Sprintf("Initializing Android notificaiton server for type=%v", me.AndroidPushSettings.Type))
./README.md:For more in-depth instructions on setting up push notificaitons with your own build please follow the directions at [docs.mattermost.com](https://docs.mattermost.com/developer/mobile-developer-setup.html#push-notifications-with-your-own-build)
Here’s a link to the line in server/android_notification_server.go, README.md link unavailable because Github doesn’t allow per-line linking to Markdown files (that I know of). I think this should be pretty easy to fix and I can provide a pull request.