@xet7 Ah yes, the backticks are a cleaner workaround.
Not sure what you meant about the description supporting markdown, as markdown formatting of the description is what I was reporting on :)
In case my wording was unclear, I didn’t mean I wanted to preserve the indentation going from the editor to the formatted view, but to use markdown’s indented code block feature, which works just fine unless the indentation occurs right at the beginning of the description (or a comment), where the starting indention is trimmed off (thus breaking the code block formatting).
Impacted version: 0.49
Server Setup Information:
- Operating System: Ubuntu 16.04
- Deployment Method: snap
- ROOT_URL environment variable (Is there a subfolder?): https://my-domain.com/kan (yes)
Steps to reproduce:
- Create a card
- Enter a description which consists entirely of a (markdown-styled) code block, i.e. indented with 4 spaces:
first line
second line
- Save the description
What happens:
The description is plain, unstylized text.
What I expect to happen:
For the description to be rendered as a code block.
How to work around this:
I have to enter at least one non-whitespace character followed by at least two newlines before entering the indented code block. Urgh :(
Impacted version: 0.49
Server Setup Information:
- Operating System: Ubuntu 16.04
- Deployment Method: snap
- ROOT_URL environment variable (Is there a subfolder?): https://my-domain.com/kan (yes)
Steps to reproduce:
- Create a card
- Click the description field’s Edit link, enter some text
- Click (for instance) on the comment field, prompting Wekan to show ”You have an unsaved description” in the description (with View it/Discard links)
- Click the description field’s Edit link again, click Save
What happens:
The description field still shows ”You have an unsaved description” with the just saved description text. The only way to make the warning go away is to select the ”Discard” link.
What I expect to happen:
I’d expect the ”You have an unsaved description” notice to disappear when the description is saved.
Impacted version: 0.39
Server Setup Information:
- Operating System: Ubuntu 16.04
- Deployment Method: snap
- ROOT_URL environment variable (Is there a subfolder?): http://localhost:5000
Steps to reproduce:
- Create a board in Trello.
- Create a list in the board.
- Create a card in the list.
- Create a checklist in the card.
- Archive the list.
- Copy the board.
- Export the new copy as JSON.
- In Wekan, initiate a Trello import.
- Map the user.
What I expect to happen:
For the board to be imported in Wekan.
What happens:
The importer reports a ’400’. journalctl -u snap.wekan.wekan.service reports
Exception while invoking method 'importBoard' Error: Card id is required
at getErrorObject (packages/aldeed_collection2-core.js:480:15)
at [object Object].doValidate (packages/aldeed_collection2-core.js:462:13)
at [object Object].Mongo.Collection.(anonymous function) [as insert] (packages/aldeed_collection2-core.js:214:25)
at packages/matb33_collection-hooks.js:127:46
at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
at Object.directOp (packages/matb33_collection-hooks.js:47:27)
at Object.self.direct.(anonymous function) [as insert] (packages/matb33_collection-hooks.js:126:30)
at models/trelloCreator.js:408:45
at Array.forEach (native)
at TrelloCreator.createChecklists (models/trelloCreator.js:400:22)
at TrelloCreator.create (models/trelloCreator.js:608:10)
at [object Object].Meteor.methods.importBoard (models/import.js:27:20)
at packages/check.js:130:16
at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
at Object.exports.Match._failIfArgumentsAreNotAllChecked (packages/check.js:129:41)
at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1734:18)
Sanitized and reported to the client as: Card id is required [400]
I’m attaching the failing JSON.
To be fair, I think the blame here mostly lies with Trello: it does not preserve archived lists when copying a board (you won’t find them from archived lists view in the copy), but for some reason it does carry the checklists contained in those lists over, and they then pop up in the export file.
Wekan’s ”Card id is required” error is slightly misleading here though: I think the problem isn’t a missing card ID, but the fact that the parent card referenced by the checklist does not come with the export.
Impacted version: 0.39
Server Setup Information:
- Operating System: Ubuntu 16.04
- Deployment Method: snap
snap info wekan reports snap-id as jtpboSYvTCEyHoutkkRo1SI9ioSMOUb3 (tracking: stable). I’m not sure how to find out Node and MongoDB versions from the snap, but if the snap ID isn’t enough, just show me how to get those version numbers and I’ll add them.
Steps to reproduce:
- Create a board in Trello.
- Create a list in the board.
- Create a card in the list.
- Create a new label in the card. Name it, then select ”No color”.
- Export the board as JSON.
- In Wekan, initiate a Trello import.
- Map the user.
What I expect to happen:
For the board to be imported in Wekan.
What happens:
The importer reports a ’400’. journalctl -u snap.wekan.wekan.service reports
Exception while invoking method 'importBoard' Error: Color is required
at getErrorObject (packages/aldeed_collection2-core.js:480:15)
at [object Object].doValidate (packages/aldeed_collection2-core.js:462:13)
at [object Object].Mongo.Collection.(anonymous function) [as insert] (packages/aldee
at packages/matb33_collection-hooks.js:127:46
at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
at Object.directOp (packages/matb33_collection-hooks.js:47:27)
at Object.self.direct.(anonymous function) [as insert] (packages/matb33_collection-h
at TrelloCreator.createBoardAndLabels (models/trelloCreator.js:195:35)
at TrelloCreator.create (models/trelloCreator.js:605:26)
at [object Object].Meteor.methods.importBoard (models/import.js:27:20)
at packages/check.js:130:16
at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
at Object.exports.Match._failIfArgumentsAreNotAllChecked (packages/check.js:129:41)
at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1734:18)
at packages/ddp-server/livedata_server.js:719:19
at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
Sanitized and reported to the client as: Color is required [400]
I’m attaching the failing JSON (with email sanitized).
I haven’t looked into what philosophical meaning Trello assigns to uncolored labels; in practice, they appear as grey in the web UI, and as nulls in the exported JSON.
Can confirm: release 0.39 fixes this. Thanks!
Impacted version: 0.38
Server Setup Information:
- Operating System: Ubuntu 16.04
- Deployment Method: snap
snap info wekan reports snap-id as jtpboSYvTCEyHoutkkRo1SI9ioSMOUb3 (tracking: stable). I’m not sure how to find out Node and MongoDB versions from the snap, but if the snap ID isn’t enough, just show me how to get those version numbers and I’ll add them.
Steps to reproduce:
- Create a board in Trello.
- Create a list in the board.
- Create a card in the list.
- Create a checklist in the card.
- Export the board as JSON.
- In Wekan, initiate a Trello import.
- Map the user.
What I expect to happen:
For the board to be imported in Wekan.
What happens:
The importer reports a ’400’. journalctl -u snap.wekan.wekan.service reports
Exception while invoking method 'importBoard' Error: Sort is required
at getErrorObject (packages/aldeed_collection2-core.js:480:15)
at [object Object].doValidate (packages/aldeed_collection2-core.js:462:13)
at [object Object].Mongo.Collection.(anonymous function) [as insert] (packag
at packages/matb33_collection-hooks.js:127:46
at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
at Object.directOp (packages/matb33_collection-hooks.js:47:27)
at Object.self.direct.(anonymous function) [as insert] (packages/matb33_coll
at models/trelloCreator.js:407:45
at Array.forEach (native)
at TrelloCreator.createChecklists (models/trelloCreator.js:400:22)
at TrelloCreator.create (models/trelloCreator.js:606:10)
at [object Object].Meteor.methods.importBoard (models/import.js:27:20)
at packages/check.js:130:16
at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
at Object.exports.Match._failIfArgumentsAreNotAllChecked (packages/check.js:
at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1734:18)
Sanitized and reported to the client as: Sort is required [400]
I’m attaching the failing JSON (with email sanitized).
Steps to reproduce
Add an image to a post, type in a caption and set alignment to ’None’.
What I expect to happen
I’d expect the captioned image to be left-aligned with the main content column’s left, in line with <p>elements.
What happens
The image is left-aligned to the left edge of the screen. My attachment is a screenshot of a post with one uncaptioned and one captioned alignnone image.
Technical details
- YOURLS version: master (at e36ec69)
- PHP version: 5.6.30
- I’m running Yourls on shared hosting and they have php5-geoip installed
Bug Summary
After pulling recent changes (up to e36ec69) today, I’ve hit what appears to be a regression of issue #359: I get a blank page and a ”Cannot redeclare geoip_country_code_by_name()” (in includes/geo/geoip.inc on line 1602) error in my log.
I can work around the issue by checking out d5a5522, which is the last commit prior to ”Update GeoIP” (96a159b).
I make no guarantees this doesn’t break something else, but for me it seems to work correctly if I make Feediron_Json::format() skip carriage returns:
$ git diff
diff --git a/Json.php b/Json.php
index c988962..fc7f554 100644
--- a/Json.php
+++ b/Json.php
@@ -8,6 +8,7 @@ class Feediron_Json{
$strLen = strlen($json);
$indentStr = ' ';
$newLine = "\n";
+ $cReturn = "\r";
$prevChar = '';
$outOfQuotes = true;
$currentline = 0;
@@ -30,6 +31,9 @@ class Feediron_Json{
$currentline++;
continue;
}
+ if($char == $cReturn){
+ continue;
+ }
if($char == ' ' && $outOfQuotes){
continue;
}
(Using PHP 5.6.30 here.)
