Viestit paikassa Github

UTF-8 support in bookmark names

13. syyskuuta 2015 klo 13.37
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Bash

I’m in a UTF-8 environment and a lot of my directories’ names have characters above ASCII in them. For many of those it’d be natural to assign bookmark names that also have characters beyond ASCII. For example, my ”Desktop” directory is localized as ~/Työpöytä, and I’d like to name that bookmark ”työpöytä”.

jani@saegusa:Työpöytä$ s työpöytä
bookmark name is not valid

This fails because bashmarks validates names using the regexp /[^A-Za-z0-9_]/. It’s simple enough to patch to account for the 6 additional characters in my Scandinavian locale, but bashmarks also derives an environment variable name from the bookmark name, and apparently Bash does not support UTF-8 for those:

jani@saegusa:~$ LC_MESSAGES=C export DIR_työpöytä=$HOME/Työpöytä/
bash: export: `DIR_työpöytä=/home/jani/Työpöytä/': not a valid identifier

There may be other obstacles as well, those are just the two I could find at a glance.

Obviously I can work around this by not using UTF-8 in bookmark names, but it needlessly increases the mental effort required to recall the names and also the chances of name collisions.

Vastaa viestiin sen kontekstissa (Github)

Just an update: upgraded to 8.1 today and the issue remains

7. heinäkuuta 2015 klo 18.47
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: ownCloud

Upgraded to 8.1 today and the issue remains.

So I set up a Debian Wheezy VM just to test this, and was able to reproduce it straight away: did a clean install of 8.1 in /var/www/owncloud/ and set the data directory to /var/www/oc (whose owner I set to www-data:www-data). After installer was finished, selecting Admin from the Admin menu immediately causes ”File does not exist: /var/www/owncloud/data” to show up in error.log.

There was also this other error associated with it (copying here by hand instead because haven’t set up copy & paste in VM yet):

touch(): Unable to create file \\/var\\/www\\/owncloud\\/data\\/owncloud.log because No such file or directory at \\/var\\/www\\/owncloud\\/lib\\/private\\/log\\/owncloud.php#53

It would seem to hint the source of this being OC_Log_Owncloud::init (which is where the line it refers to belongs to AFAICT). For some reason this message about touch() failing does not show up on my actual installation’s logs (the one I pasted the logs from in the initial report above). It no longer seems to show up in the VM either after I raised logging level up to ”Errors and fatal issues”; not even after I lower it back down to ”Info, warnings, errors and fatal issues”; only the ”File does not exist: /var/www/owncloud/data” still keeps appearing. Perhaps the vanishing of that other message is also caused by the same problem with OC_Log_Owncloud::init.

Vastaa viestiin sen kontekstissa (Github)

Done, hopefully!

29. kesäkuuta 2015 klo 18.29
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Github

@PeterDaveHello done, hopefully right this time! Thanks for guiding me through this (it’s my first pull request, in case you couldn’t tell).

Vastaa viestiin sen kontekstissa (Github)

The issues you mentioned should now be fixed

29. kesäkuuta 2015 klo 16.17
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: Github

Hi @PeterDaveHello, the issues you mentioned should now be fixed. (I’m making this comment in case you’re not receiving notifications about the fix commits and test automaton pass, but do tell if more fixes are needed.)

Vastaa viestiin sen kontekstissa (Github)

Trying to get property of non-object in … inc/template-tags.php on line 61

26. kesäkuuta 2015 klo 18.57
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: WordPress

Hi,

I’m getting this entry in my server log when I open the latest post in single-post view:

Trying to get property of non-object in [...]/wp-content/themes/cover/inc/template-tags.php on line 61

It looks like the reference to $next->ID on said line is causing this; there’s no next post from the newest, obviously. There is a test for ! $next && ! $previous on line 51, but I’m guessing the block generating$next_img_array for next_post_link should also be wrapped with a separate test for the existence of$next, to suppress the error.

Vastaa viestiin sen kontekstissa (Github)

I disabled all apps and the issue remains

16. kesäkuuta 2015 klo 17.27
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: ownCloud

Okay, I disabled all apps and the issue remains: the log still gets a new ”not exist” entry when I select ”Admin”.

Vastaa viestiin sen kontekstissa (Github)

Ha, got it!

15. kesäkuuta 2015 klo 18.49
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: ownCloud

Ha, got it! It’s the act of selecting ”Admin” from the ”admin” dropdown menu (top right) that triggers it. Nothing else seems to do it (”Users” from the same menu for example doesn’t trigger it).

There’s now also this in the log:

File does not exist: /var/www/userhome/mummila/sites/mummila.kapsi.fi/secure-www/oc/assets/dist, referer: https://mummila.kapsi.fi/oc/index.php/apps/gallery/

But I’d wager it’s completely unrelated to the other ”not exist”, as I only activated asset-pipeline yesterday. Browser’s JS log says it’s missing assets/dist/jquery-migrate.min.map; it doesn’t say anything about the data directory that the server log complains about.

While poking around, I also noticed that for my non-admin OC user, selecting Pictures from the Apps menu brings up the Pictures view, but it fails to load any pictures. The loading spinner just keeps spinning forever. The admin user’s Pictures view does work, i.e. it actually loads the pictures too. I’m not sure if this is related to the log issue either, but thought I’d mention it anyway.

Any ideas on how I can narrow this down further?

Vastaa viestiin sen kontekstissa (Github)

I’ve haphazardly tried it already, but I’ll give it a proper go

15. kesäkuuta 2015 klo 16.04
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: ownCloud

@schiesbn Sure. I’ve haphazardly tried it already, but I’ll give it a proper go sometime soon.

Vastaa viestiin sen kontekstissa (Github)

With data directory outside www root, ”File does not exist: [OC root directory]/data” in Apache’s error.log

14. kesäkuuta 2015 klo 15.29
Sijainti: Vianhallintajärjestelmät: Github
Avainsanat: ownCloud

### Description
The Apache log file for my Owncloud site sporadically registers ”File does not exist: *[my OC root directory]*/data” errors from Owncloud; these go back to at least July last year (2014). To me this appears as if OC was erroneusly trying to access a hard-coded path for the data directory under the OC root, whereas my data directory actually resides elsewhere, entirely outside www my root, and there is no data directory under OC root.

The error timestamps indicate they only occur during daytime when I’m interacting with my installation (I’m the sole user), possibly only through the web interface, as I have the desktop client always on but the errors are rare relative to that. I use the web interface less and I think it corresponds to the timestamps better (but not all web interactions result in the error either, and I haven’t been able to pinpoint any specific action that triggers it).

Apart from those errors in the log my Owncloud installation appears work just fine, so the issue seems pretty harmless. I’ve considered creating an empty data directory under the OC root in case that might make the error go away, but then again it might just break something. Anyway, because it looks like a bug, I figured I’d better report it.

### Server configuration
**Operating system**: Debian Wheezy (I think; I’m a non-privileged user on shared hosting)

**Web server:** Apache/2.2

**Database:** MySQL 5.5.43

**PHP version:** 5.4.39-0+deb7u2

**ownCloud version:** 8.0.4.2

**Updated from an older ownCloud or fresh install:** updated

**List of activated apps:**
* Activity 1.2.0
* Deleted files 0.6.2
* External storage support 0.2.3
* First Run Wizard 1.1
* PDF Viewer 0.7
* Pictures 0.6.0
* Share Files 0.6.1
* Text Editor 0.4
* Updater 0.4
* Versions 1.0.5
* Video Viewer 0.1.3

**The content of config/config.php:**

”`
’datadirectory’ => ’/siilo/users/mummila/owncloud-data’,
’asset-pipeline.enabled’ => true,
’dbtableprefix’ => ’oc_’,
’dbtype’ => ’mysql’,
’forcessl’ => true,
’installed’ => true,
’logdateformat’ => ’l, j. F Y’,
’loglevel’ => 3,
’mail_smtpmode’ => ’smtp’,
’mail_smtpport’ => ’465’,
’mail_smtpsecure’ => ’ssl’,
’maintenance’ => false,
’max_filesize_animated_gifs_public_sharing’ => 5,
’preview_max_filesize_image’ => 5,
’session_lifetime’ => 60 * 60 * 24 * 15,
’theme’ => ”,
’version’ => ’8.0.4.2’,
”`

**Are you using external storage, if yes which one:** none

**Are you using encryption:** no

**Are you using an external user-backend, if yes which one:** none

### Client configuration
**Browser:** Chromium 37.0.2062.120 (build 281580)

**Operating system:** Ubuntu 12.04

### Logs
#### Web server error log
”`
[Sun Jun 14 13:57:52 2015] [error] [client 217.30.184.173] File does not exist: /var/www/use
rhome/mummila/sites/mummila.kapsi.fi/secure-www/oc/data
[Sun Jun 14 13:58:47 2015] [error] [client 217.30.184.173] File does not exist: /var/www/use
rhome/mummila/sites/mummila.kapsi.fi/secure-www/oc/data
[Sun Jun 14 14:29:18 2015] [error] [client 217.30.184.173] File does not exist: /var/www/use
rhome/mummila/sites/mummila.kapsi.fi/secure-www/oc/data
”`

#### ownCloud log (data/owncloud.log)

(No recent events coinciding with the log above. Last entry below, with my desktop IP address redacted, from two days ago)
”`
{”reqId”:”71513d1b6f44276a8cd6cad21bc98864″,”remoteAddr”:”[my desktop IP]”,”app”:”PHP”,”message”:”Undefined index: extension at \/var\/www\/userhome\/mummila\/sites\/mummila.kapsi.fi\/www\/oc\/apps\/files_versions\/lib\/storage.php#320″,”level”:3,”time”:”2015-06-12T04:37:22+00:00″}
”`

Vastaa viestiin sen kontekstissa (Github)

The change is working perfectly

1. toukokuuta 2015 klo 13.30
Sijainti: Vianhallintajärjestelmät: Github

@trentrichardson I’ve just tested the branch with the change and it’s working perfectly.

Vastaa viestiin sen kontekstissa (Github)

« Uudempia - Vanhempia »